[
https://issues.apache.org/jira/browse/YARN-11898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18039688#comment-18039688
]
ASF GitHub Bot commented on YARN-11898:
---------------------------------------
steveloughran commented on code in PR #8096:
URL: https://github.com/apache/hadoop/pull/8096#discussion_r2547422984
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java:
##########
@@ -474,6 +476,7 @@ public synchronized void startInternal() throws Exception {
}
@Test
+ @Timeout(value=60, unit = TimeUnit.SECONDS, threadMode = SEPARATE_THREAD)
Review Comment:
interesting...I don't see that `threadMode` option in the junit5 version my
IDE is bringing up.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestRMHA.java:
##########
@@ -610,7 +613,7 @@ protected void serviceStart() throws Exception {
}
@Test
- @Timeout(value = 9000)
+ @Timeout(value = 9000) // FIXME that's more than two hours
Review Comment:
I thought maybe this was just 9000 millis with a new default, but no, the
old timeout was 900000 mills, so now its just in a different unit.
I think the value here is to ensure that it never hangs the build forever,
its just a very big one. Looking at the history of that line, YARN-4927
multiplied the timeout up from 90 seconds, so it was probably just "a number
which made the failures go away".
I'd propose 10 minutes.
> TestRMHA.testTransitionedToStandbyShouldNotHang hangs
> -----------------------------------------------------
>
> Key: YARN-11898
> URL: https://issues.apache.org/jira/browse/YARN-11898
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: test, yarn
> Reporter: Istvan Toth
> Assignee: Istvan Toth
> Priority: Major
> Labels: pull-request-available
>
> TestRMHA.testTransitionedToStandbyShouldNotHang hangs.
> This happens both on branch-3.4 and trunk, but on branch-3.4 the tests uses
> Junit4, and is silently killed after a short while.
> The same test on trunk uses Junit 5 and hangs forever.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
