[ 
https://issues.apache.org/jira/browse/YARN-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18047169#comment-18047169
 ] 

ASF GitHub Bot commented on YARN-11912:
---------------------------------------

cnauroth opened a new pull request, #8143:
URL: https://github.com/apache/hadoop/pull/8143

   ### Description of PR
   
   Suppress Spotbugs warnings introduced in recent trunk changes
   
   1. There was a pre-existing exclusion of a potential NPE warning in 
`ResourceLocalizationService`. #8062 changed the relevant method from `run()` 
to `work()`, so the exclusion needs a corresponding change to match.
   2. The Spotbugs upgrade triggered numerous new warnings. #8053 was intended 
to update exclusions to cover these new warnings. I think that just missed a 
thread synchronization warning in `ResourceManager`.
   
   ### How was this patch tested?
   
   1. Run `mvn -o test-compile spotbugs:spotbugs -DskipTests` locally.
   2. Confirm the warnings are no longer present in 
`hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/target/spotbugs.xml`.
   
   ### For code changes:
   
   - [X] Does the title or this PR starts with the corresponding JIRA issue id 
(e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the 
endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, 
`NOTICE-binary` files?
   
   




> Suppress Spotbugs warnings introduced in recent trunk changes
> -------------------------------------------------------------
>
>                 Key: YARN-11912
>                 URL: https://issues.apache.org/jira/browse/YARN-11912
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: buid
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>
> A few recent changes introduced new Spotbugs warnings that are not 
> immediately actionable. We can update exclusion rules to cover these new 
> warnings. The intent of this is not to fix any existing bugs flagged by 
> Spotbugs (which might be legitimate) but rather just restore previous status 
> quo of the build.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to