[ 
https://issues.apache.org/jira/browse/YARN-11698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056254#comment-18056254
 ] 

ASF GitHub Bot commented on YARN-11698:
---------------------------------------

hadoop-yetus commented on PR #6845:
URL: https://github.com/apache/hadoop/pull/6845#issuecomment-3842412294

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m  0s |  |  Docker mode activated.  |
   | -1 :x: |  patch  |   0m 44s |  |  
https://github.com/apache/hadoop/pull/6845 does not apply to trunk. Rebase 
required? Wrong Branch? See 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.  
|
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-6845/9/console |
   | versions | git=2.34.1 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Finished containers shouldn't be stored indefinitely in the NM state store
> --------------------------------------------------------------------------
>
>                 Key: YARN-11698
>                 URL: https://issues.apache.org/jira/browse/YARN-11698
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.4.0
>            Reporter: Adam Binford
>            Priority: Major
>              Labels: pull-request-available
>
> https://issues.apache.org/jira/browse/YARN-4771 updated the container 
> tracking in the state store to only remove containers when their application 
> ends, in order to make sure all containers logs get aggregated even during NM 
> restarts. This can lead to a significant number of containers building up in 
> the state store and a lot of things to recover. Since this was purely for 
> making sure logs get aggregated, it could be done smarter that takes into 
> account both rolling log aggregation or not having log aggregation enabled at 
> all.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to