[ 
https://issues.apache.org/jira/browse/YARN-11831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18056255#comment-18056255
 ] 

ASF GitHub Bot commented on YARN-11831:
---------------------------------------

hadoop-yetus commented on PR #7758:
URL: https://github.com/apache/hadoop/pull/7758#issuecomment-3842415926

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m  0s |  |  Docker mode activated.  |
   | -1 :x: |  patch  |   0m 47s |  |  
https://github.com/apache/hadoop/pull/7758 does not apply to trunk. Rebase 
required? Wrong Branch? See 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute for help.  
|
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Console output | 
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-7758/8/console |
   | versions | git=2.34.1 |
   | Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   




> Docker executor does not signal applications with kill
> ------------------------------------------------------
>
>                 Key: YARN-11831
>                 URL: https://issues.apache.org/jira/browse/YARN-11831
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 3.4.1
>            Reporter: Adam Binford
>            Priority: Major
>              Labels: pull-request-available
>
> With the Docker runtime, applications do not receive signals from the 
> NodeManagers and are not able to exit cleanly. This is because the root 
> process in the container is "bash -c", as set by the UnixShellScriptBuilder, 
> and bash does not forward signals to its child processes.
> This only affects the Docker runtime because other Linux runtimes use the 
> system "kill" command with the process group ID, not just the PID, so all 
> child processes receive the kill signal even if the parent process doesn't 
> forward it.
> The fix is either:
> - Remove the "bash -c" process from the tree, I'm not sure why this needs to 
> exist as the launch_container.sh script is already running in bash to begin 
> with.
> - Use the system kill command on the PID reported by docker instead of using 
> "docker kill"



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to