[ 
https://issues.apache.org/jira/browse/YARN-11823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18058170#comment-18058170
 ] 

ASF GitHub Bot commented on YARN-11823:
---------------------------------------

Hean-Chhinling commented on code in PR #8123:
URL: https://github.com/apache/hadoop/pull/8123#discussion_r2799529238


##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/DiagnosticJStackService.java:
##########
@@ -0,0 +1,134 @@
+/** * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.yarn.server.nodemanager.webapp;
+
+import org.apache.hadoop.util.Shell;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+
+import java.io.IOException;
+import java.util.ArrayList;
+import java.util.List;
+
+public class DiagnosticJStackService {
+
+    private static final Logger LOG = LoggerFactory
+            .getLogger(DiagnosticJStackService.class);
+
+    public static String collectNodeThreadDump(int numberOfJStack)
+            throws Exception {
+        if (Shell.WINDOWS) {
+            throw new UnsupportedOperationException("Not implemented for 
Windows");
+        }
+
+        List<String> nodeManagerPids = getNodeManagerPids();
+
+        return runJStack(nodeManagerPids, numberOfJStack);
+
+    }
+
+
+
+    public static String collectApplicationThreadDump(String appId, int 
numberOfJStack)
+            throws Exception {
+        if (Shell.WINDOWS) {
+            throw new UnsupportedOperationException("Not implemented for 
Windows.");
+        }
+        List<String> applicationPids = getApplicationPids(appId);
+
+        return runJStack(applicationPids, numberOfJStack);
+    }
+
+
+    public static List<String> getNodeManagerPids() throws IOException {
+        Shell.ShellCommandExecutor cmd = new Shell.ShellCommandExecutor(
+                new String[]{
+                        "bash",
+                        "-c",
+                        "ps aux | grep nodemanager | grep -v grep"

Review Comment:
   With `ps aux | grep org.apache.hadoop.yarn.server.nodemanager.NodeManager | 
grep -v grep`





> New JStack endpoint for running containers and nodes
> ----------------------------------------------------
>
>                 Key: YARN-11823
>                 URL: https://issues.apache.org/jira/browse/YARN-11823
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: yarn
>            Reporter: chhinlinghean
>            Assignee: chhinlinghean
>            Priority: Major
>              Labels: pull-request-available
>
> Getting jstack for container is not trivial to most people. This new endpoint 
> aims to streamline the process of getting jstack of running containers and 
> nodes. It mainly use in the DiagnosticCollector script.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to