[
https://issues.apache.org/jira/browse/YARN-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18078872#comment-18078872
]
ASF GitHub Bot commented on YARN-11960:
---------------------------------------
magnuma3 opened a new pull request, #8473:
URL: https://github.com/apache/hadoop/pull/8473
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
In Spark or MapReduce jobs, when accessing private Docker registry, Docker
config.json path can be set by below environment variable:
```
YARN_CONTAINER_RUNTIME_DOCKER_CLIENT_CONFIG=hdfs://ns/user/foo/config.json
```
NodeManager reads this file and writes to local filesystem as config.json.
But current implementation reads whole file to memory and do JSON parsing, then
writes it.
If large file is configured, NodeManager can occur OOM.
So file size limit should be added.
### How was this patch tested?
unit test
### For code changes:
- [x] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
### AI Tooling
If an AI tool was used:
- [ ] The PR includes the phrase "Contains content generated by <tool>"
where <tool> is the name of the AI tool used.
- [ ] My use of AI contributions follows the ASF legal policy
https://www.apache.org/legal/generative-tooling.html
> Fix NodeManager OOM caused by large client.json
> -----------------------------------------------
>
> Key: YARN-11960
> URL: https://issues.apache.org/jira/browse/YARN-11960
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: KWON BYUNGCHANG
> Priority: Major
> Attachments: YARN-11960.001.patch
>
>
> In Spark or MapReduce jobs, when accessing private Docker registry, Docker
> config.json path can be set by below environment variable:
> {noformat}
> YARN_CONTAINER_RUNTIME_DOCKER_CLIENT_CONFIG=hdfs://ns/user/foo/config.json
> {noformat}
> NodeManager reads this file and writes to local filesystem as config.json.
> But current implementation reads whole file to memory and do JSON parsing,
> then writes it.
> If large file is configured, NodeManager can occur OOM.
> So file size limit should be added.
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
