[
https://issues.apache.org/jira/browse/YARN-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864759#comment-13864759
]
Jian He commented on YARN-1506:
-------------------------------
- Instead of the check here, I think we can send the event and make
RMNodeTransition to ignore this event. This can prevent the case that
isUnusable return true right before the node is about to become usable, since
the events will be processed sequentially.
{code}
else if (node.getState().isUnusable()) {
LOG.warn("Resource update get failed on an unusable node: " + nodeId);
{code}
- Did we have an overall test for testing AdminService to send the request and
verify RMNode and schedulerNode are changed accordingly?
Patch looks good to me mostly, [~bikassaha]/ [~vinodkv] you may also want to
take a look.
> Replace set resource change on RMNode/SchedulerNode directly with event
> notification.
> -------------------------------------------------------------------------------------
>
> Key: YARN-1506
> URL: https://issues.apache.org/jira/browse/YARN-1506
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, scheduler
> Reporter: Junping Du
> Assignee: Junping Du
> Priority: Blocker
> Attachments: YARN-1506-v1.patch, YARN-1506-v2.patch,
> YARN-1506-v3.patch, YARN-1506-v4.patch, YARN-1506-v5.patch
>
>
> According to Vinod's comments on YARN-312
> (https://issues.apache.org/jira/browse/YARN-312?focusedCommentId=13846087&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13846087),
> we should replace RMNode.setResourceOption() with some resource change event.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
