[
https://issues.apache.org/jira/browse/YARN-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864969#comment-13864969
]
Jian He commented on YARN-1166:
-------------------------------
patch looks good overall.
- In FairScheduler, log if application == null ?
{code}
private synchronized void removeApplication(ApplicationId applicationId,
RMAppState finalState) {
SchedulerApplication application = applications.get(applicationId);
if (application == null){
return;
}
{code}
- There are things other than queue metrics. For example,
LeafQueue.activeApplications and PendingApplications. These two are actually
recording the attempts. But I remember those two are exposed on scheduler UI as
schedulable and non-schedulable apps. Can you check if these two collections
are also needed be associated with application ?
> YARN 'appsFailed' metric should be of type 'counter'
> ----------------------------------------------------
>
> Key: YARN-1166
> URL: https://issues.apache.org/jira/browse/YARN-1166
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.1.0-beta
> Reporter: Srimanth Gunturi
> Assignee: Zhijie Shen
> Priority: Blocker
> Attachments: YARN-1166.2.patch, YARN-1166.3.patch, YARN-1166.4.patch,
> YARN-1166.5.patch, YARN-1166.6.patch, YARN-1166.patch
>
>
> Currently in YARN's queue metrics, the cumulative metric 'appsFailed' is of
> type 'guage' - which means the exact value will be reported.
> All other cumulative queue metrics (AppsSubmitted, AppsCompleted, AppsKilled)
> are all of type 'counter' - meaning Ganglia will use slope to provide deltas
> between time-points.
> To be consistent, AppsFailed metric should also be of type 'counter'.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
