[
https://issues.apache.org/jira/browse/YARN-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Junping Du updated YARN-1569:
-----------------------------
Description:
As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we should
always check appropriate type before casting.
handle(SchedulerEvent) in FifoScheduler and CapacityScheduler didn't check so
far (no bug there now) but should be improved as FairScheduler.
was:As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we
should always check appropriate type before casting. handle(SchedulerEvent) in
FifoScheduler and CapacityScheduler didn't check so far (no bug there now) but
should be improved as FairScheduler.
> For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler,
> SchedulerEvent should get checked (instanceof) for appropriate type before
> casting
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-1569
> URL: https://issues.apache.org/jira/browse/YARN-1569
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Reporter: Junping Du
> Priority: Minor
> Labels: newbie
>
> As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we should
> always check appropriate type before casting.
> handle(SchedulerEvent) in FifoScheduler and CapacityScheduler didn't check so
> far (no bug there now) but should be improved as FairScheduler.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
