[ 
https://issues.apache.org/jira/browse/YARN-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865123#comment-13865123
 ] 

Sandy Ryza commented on YARN-1041:
----------------------------------

Took a look at the Fair Scheduler changes.  A couple nits:
{code}
+    ContainerId amContainerId =
+        this.rmContext.getRMApps().get(applicationId).getCurrentAppAttempt()
+          .getMasterContainer().getId();
{code}
Other references to rmContext in this file do not use "this".

{code}
+
   private SchedulerApplicationAttempt getCurrentAttemptForContainer(
       ContainerId containerId) {
     SchedulerApplication app =
@@ -1361,5 +1384,4 @@ public void onReload(AllocationConfiguration queueInfo) {
     queue.collectSchedulerApplications(apps);
     return apps;
   }
-
{code}
False whitespace changes

> Protocol changes for RM to bind and notify a restarted AM of existing 
> containers
> --------------------------------------------------------------------------------
>
>                 Key: YARN-1041
>                 URL: https://issues.apache.org/jira/browse/YARN-1041
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Jian He
>         Attachments: YARN-1041.1.patch
>
>
> For long lived containers we don't want the AM to be a SPOF.
> When the RM restarts a (failed) AM, it should be given the list of containers 
> it had already been allocated. the AM should then be able to contact the NMs 
> to get details on them. NMs would also need to do any binding of the 
> containers needed to handle a moved/restarted AM.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to