[ 
https://issues.apache.org/jira/browse/YARN-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13866326#comment-13866326
 ] 

Zhijie Shen commented on YARN-1345:
-----------------------------------

bq. I think Jian He deliberately didn't add FINAL_SAVING and instead exposed 
the last state before FINAL_SAVING.
Right, this has been done for RMAppState, but not RMAppAttemptState

bq. Don't think we need this but I'll let him comment on more details.
Agree, I added the mapping in createApplicationAttemptState because anyway I 
have to edit the conflicts in this method. How about moving one with this patch 
for merging commit to the latest trunk? Meanwhile, let's leave this ticket 
open, and create a stand-alone patch to correct state mapping later.

> RMServerUtils#createApplicationAttemptState needs to add the mapping for 
> FINAL_SAVING
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-1345
>                 URL: https://issues.apache.org/jira/browse/YARN-1345
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-1345.1.patch
>
>
> Whenever YARN-891 is done, we need to add the mapping of 
> RMAppAttemptState.FINAL_SAVING -> YarnApplicationAttemptState.FINAL_SAVING in 
> RMServerUtils#createApplicationAttemptState



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to