[
https://issues.apache.org/jira/browse/YARN-1166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhijie Shen updated YARN-1166:
------------------------------
Attachment: YARN-1166.8.patch
Thanks Vinod and Jian for your review. I uploaded a new patch.
bq. One comment other than Jian's. runAppAttempt API can just take in an
ApplicationID? Similarly, finishAppAttempt can just take appId and user.
Refactoring the code accordingly.
bq. @zhijie, last time I checked YARN-915 should be caused by this. If so, can
you add a unit test for the restart scenario. thanks!
The test case for RM restart is added.
> YARN 'appsFailed' metric should be of type 'counter'
> ----------------------------------------------------
>
> Key: YARN-1166
> URL: https://issues.apache.org/jira/browse/YARN-1166
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.1.0-beta
> Reporter: Srimanth Gunturi
> Assignee: Zhijie Shen
> Priority: Blocker
> Attachments: YARN-1166.2.patch, YARN-1166.3.patch, YARN-1166.4.patch,
> YARN-1166.5.patch, YARN-1166.6.patch, YARN-1166.7.patch, YARN-1166.8.patch,
> YARN-1166.patch
>
>
> Currently in YARN's queue metrics, the cumulative metric 'appsFailed' is of
> type 'guage' - which means the exact value will be reported.
> All other cumulative queue metrics (AppsSubmitted, AppsCompleted, AppsKilled)
> are all of type 'counter' - meaning Ganglia will use slope to provide deltas
> between time-points.
> To be consistent, AppsFailed metric should also be of type 'counter'.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)