[
https://issues.apache.org/jira/browse/YARN-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883587#comment-13883587
]
Bikas Saha commented on YARN-1618:
----------------------------------
Is this related? Does not look like a compatible change. If it was valid
earlier then we should not change the logic now.
{code}
- Assert.assertTrue("application finish time is not greater then 0",
- (application.getFinishTime() > 0));
+ Assert.assertTrue("application start time is less than 0",
+ (application.getStartTime() >= 0));
{code}
I am not sure this would happen in real life since only a START event would
trigger going to the scheduler and introduce the possibility of a REJECTED
event. If that is the case then this transition should not exist since it would
be a bug if this got triggered.
{code}
+ .addTransition(RMAppState.NEW, RMAppState.FAILED,
+ RMAppEventType.APP_REJECTED, new AppRejectedTransition())
{code}
We should add a testAppNewKilled() test and possibly remove the
testAppNewReject() if the previous comment is correct.
> Applications transition from NEW to FINAL_SAVING, and try to update
> non-existing entries in the state-store
> -----------------------------------------------------------------------------------------------------------
>
> Key: YARN-1618
> URL: https://issues.apache.org/jira/browse/YARN-1618
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.2.0
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Priority: Blocker
> Attachments: yarn-1618-1.patch, yarn-1618-2.patch
>
>
> YARN-891 augments the RMStateStore to store information on completed
> applications. In the process, it adds transitions from NEW to FINAL_SAVING.
> This leads to the RM trying to update entries in the state-store that do not
> exist. On ZKRMStateStore, this leads to the RM crashing.
> Previous description:
> ZKRMStateStore fails to handle updates to znodes that don't exist. For
> instance, this can happen when an app transitions from NEW to FINAL_SAVING.
> In these cases, the store should create the missing znode and handle the
> update.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
