[ https://issues.apache.org/jira/browse/YARN-1498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13885973#comment-13885973 ]
Karthik Kambatla commented on YARN-1498: ---------------------------------------- Comments: # AppSchedulingInfo: Not sure I understand the relevance of the following change to this JIRA. Am I missing something or is it just cleanup? {code} - metrics.incrPendingResources(user, request.getNumContainers() - - lastRequestContainers, Resources.subtractFrom( // save a clone - Resources.multiply(request.getCapability(), request - .getNumContainers()), Resources.multiply(lastRequestCapability, - lastRequestContainers))); + metrics.incrPendingResources(user, request.getNumContainers(), + request.getCapability()); + metrics.decrPendingResources(user, lastRequestContainers, + lastRequestCapability); {code} # Can we throw an Exception instead of returning null. {code} @Override public ActiveUsersManager getActiveUsersManager() { // Should never be called since all applications are submitted to LeafQueues return null; } {code} Otherwise, looks good to me. > Common scheduler changes for moving apps between queues > ------------------------------------------------------- > > Key: YARN-1498 > URL: https://issues.apache.org/jira/browse/YARN-1498 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Affects Versions: 2.2.0 > Reporter: Sandy Ryza > Assignee: Sandy Ryza > Attachments: YARN-1498-1.patch, YARN-1498.patch, YARN-1498.patch > > > This JIRA is to track changes that aren't in particular schedulers but that > help them support moving apps between queues. In particular, it makes sure > that QueueMetrics are properly updated when an app changes queue. -- This message was sent by Atlassian JIRA (v6.1.5#6160)