[
https://issues.apache.org/jira/browse/YARN-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Billie Rinaldi updated YARN-1659:
---------------------------------
Attachment: YARN-1659-6.patch
Attaching a new patch including the following changes:
* converted the interface to use the user-facing objects where possible (this
involved some modifications and additions to the user-facing objects, which are
included in this patch)
* added javadocs
* set interface audience appropriately
* addressed the comment for the GenericObjectMapper and removed it from this
patch, will include it in a patch for YARN-1635
* documented default limit
* changed fields to fieldsToRetrieve
* checked initial line of license blocks
I think the only comment I haven't addressed is adding underscores into the
Field enum values. I don't think we should make this change, as the enum
values currently match the names of the optional member variables of the
ATSEntity object.
Please let me know if I missed anything or if you have any additional comments
for the new patch. One thing I am unsure of is the best method to return error
codes in the new ATSPutErrors class. Currently an error code is just an
integer, but could easily be an enum instead.
> Define ApplicationTimelineStore interface and store-facing entity,
> entity-info and event objects
> ------------------------------------------------------------------------------------------------
>
> Key: YARN-1659
> URL: https://issues.apache.org/jira/browse/YARN-1659
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1659-1.patch, YARN-1659-3.patch, YARN-1659-4.patch,
> YARN-1659-5.patch, YARN-1659-6.patch, YARN-1659.2.patch
>
>
> These will be used by ApplicationTimelineStore interface. The web services
> will convert the store-facing obects to the user-facing objects.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
