[
https://issues.apache.org/jira/browse/YARN-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13888803#comment-13888803
]
Zhijie Shen commented on YARN-1637:
-----------------------------------
Upload a new patch.
bq. We don't need separate constants like ATS_WEBAPP_ADDRESS etc. We don't need
to declare these separate addresses.
bq. Similarly the constants for the defaults.
Done
bq. Rename ATSClient to something like TimelineClient ?
bq. Similarly the implementation and all other references.
bq. Actually, should we also drop 'ATS' prefix from the user-facing events?
Done
bq. Remove the references to the REST API in the documentation of ATSClient. It
may or may not be REST in the future, it's an implementation detail.
bq. Similarly fix the exception messages in ATSClientImpl to not refer to rest
API.
Done
bq. Document YarnJacksonJaxbJsonProvider - javadoc etc. Is it needed in this
patch? If not let's push it out to the patches where it is needed.
Add a javadoc. Yes, it's required by TimelineClientImpl, which will help
serialize the pojo objects into the json format that the server side can
deserialize back to the corresponding pojo objects.
> Implement a client library for java users to post entities+events
> -----------------------------------------------------------------
>
> Key: YARN-1637
> URL: https://issues.apache.org/jira/browse/YARN-1637
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Zhijie Shen
> Attachments: YARN-1637.1.patch, YARN-1637.2.patch
>
>
> This is a wrapper around the web-service to facilitate easy posting of
> entity+event data to the time-line server.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
