[ 
https://issues.apache.org/jira/browse/YARN-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890351#comment-13890351
 ] 

Zhijie Shen commented on YARN-1637:
-----------------------------------

[~sandyr], thanks for your review.

bq. What's the need for the PutErrors and Events classes? They appear to just 
wrap list objects?

It's needed because there should be something that works as the root element of 
XML content. We did something similar before, such as AppsInfo. However, in the 
early version, we may just support JSON content by making use of 
JacksonJaxbJsonProvider, it may be fine to remove them now, if you oppose the 
wrappers. Anyway, we should expect the POJO classes may involve with supporting 
XML content as well.

It remind me that PutErrors gets annotated, and it's supposed to be return to 
the client to show the error of posting each individual entity. The client 
needs to be updated. Cancel the patch.

> Implement a client library for java users to post entities+events
> -----------------------------------------------------------------
>
>                 Key: YARN-1637
>                 URL: https://issues.apache.org/jira/browse/YARN-1637
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Zhijie Shen
>         Attachments: YARN-1637.1.patch, YARN-1637.2.patch, YARN-1637.3.patch, 
> YARN-1637.4.patch
>
>
> This is a wrapper around the web-service to facilitate easy posting of 
> entity+event data to the time-line server.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to