[
https://issues.apache.org/jira/browse/YARN-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Billie Rinaldi updated YARN-1717:
---------------------------------
Attachment: YARN-1717.4.patch
I found an issue with the simple internal change to primary filters. While the
internal switch to using a list instead of a map is sufficient to enable
deletion of entries, a map cannot be correctly recovered from it. Therefore I
think the user API should change primary filters from a simple map to a
multimap, like related entities. While testing this solution I noticed that
the current multimap Map<String,List> allows repeated identical values in the
List, so I believe a more accurate representation would be Map<String,Set> for
both related entities and primary filters.
> Misc improvements to leveldb timeline store
> -------------------------------------------
>
> Key: YARN-1717
> URL: https://issues.apache.org/jira/browse/YARN-1717
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1717.1.patch, YARN-1717.2.patch, YARN-1717.3.patch,
> YARN-1717.4.patch
>
>
> The leveldb timeline store implementation needs the following:
> * better documentation of its internal structures
> * braces for all control flow statements
> * simple locking to prevent issues related to concurrent writes
> * internal changes to enable deleting entities
> ** never overwrite existing primary filter entries
> ** add hidden reverse pointers to related entities
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
