[
https://issues.apache.org/jira/browse/YARN-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901546#comment-13901546
]
Hadoop QA commented on YARN-1732:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12629033/YARN-1732.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3108//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3108//console
This message is automatically generated.
> Change types of related entities and primary filters in ATSEntity
> -----------------------------------------------------------------
>
> Key: YARN-1732
> URL: https://issues.apache.org/jira/browse/YARN-1732
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Billie Rinaldi
> Assignee: Billie Rinaldi
> Attachments: YARN-1732.1.patch, YARN-1732.2.patch
>
>
> The current types Map<String, List<String>> relatedEntities and Map<String,
> Object> primaryFilters have issues. The List<String> value of the related
> entities map could have multiple identical strings in it, which doesn't make
> sense. A more major issue is that we cannot allow primary filter values to be
> overwritten, because otherwise we will be unable to find those primary filter
> entries when we want to delete an entity (without doing a nearly full scan).
> I propose changing related entities to Map<String, Set<String>> and primary
> filters to Map<String, Set<Object>>. The basic methods to add primary
> filters and related entities are of the form add(key, value) and will not
> need to change.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
