[
https://issues.apache.org/jira/browse/YARN-1428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902191#comment-13902191
]
Jian He commented on YARN-1428:
-------------------------------
patch looks good overall, one nit
- TestRMAppAttemptTransitions, we may also cover the finished state scenario.
Also, we can create a common function for testing the expected final state.
similarly for TestRMAppTransition.
> RM cannot write the final state of RMApp/RMAppAttempt to the application
> history store in the transition to the final state
> ---------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-1428
> URL: https://issues.apache.org/jira/browse/YARN-1428
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-1428.1.patch, YARN-1428.2.patch
>
>
> ApplicationFinishData and ApplicationAttemptFinishData are written in the
> final transitions of RMApp/RMAppAttempt respectively. However, in the
> transitions, getState() is not getting the state that RMApp/RMAppAttempt is
> going to enter, but prior one.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
