[ https://issues.apache.org/jira/browse/YARN-1765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917295#comment-13917295 ]
Xuan Gong commented on YARN-1765: --------------------------------- bq. failOverAndKillAppWithoutAttempt -> failOverAndKillApp. Let's just distinguish the methods by the number of args DONE bq. Reuse common code between failOverAndKillApp and failOverAndKillAppWithoutAttempt DONE bq. In both the methods, rename rmAppState to initialRMAppState, rmAppAttemptState to initialRMAppAttemptState, expectedAppState to expectedAppStateBeforeKillApp DONE bq. Reorder arguments of failOverAndKillApp to be initialRMAppState, initialRMAppAttemptState followed by expectedAppStateBeforeKillApp DONE bq. Reuse common code between startRMs, startRMsWithCustomizedRMAppManager and startRMsWithCustomizedClientRMService. DONE bq. In testKillAppWhenFailOverHappensDuringApplicationKill, can you ensure that the app is in running state before the first kill? DONE > Write test cases to verify that killApplication API works in RM HA > ------------------------------------------------------------------ > > Key: YARN-1765 > URL: https://issues.apache.org/jira/browse/YARN-1765 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Xuan Gong > Assignee: Xuan Gong > Attachments: YARN-1765.1.patch, YARN-1765.2.patch, YARN-1765.2.patch > > -- This message was sent by Atlassian JIRA (v6.1.5#6160)