[
https://issues.apache.org/jira/browse/YARN-986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918755#comment-13918755
]
Vinod Kumar Vavilapalli commented on YARN-986:
----------------------------------------------
Some more comments:
- Let's mark YarnConfiguration.getClusterId() as Private
- Can we move the getRMDelegationTokenService() API to ClientRMProxy? (The
later BTW is missing the visibility annotations). That seems like a better
place.
- There are some related TODOs in ClientRMProxy.setupTokens() that we put
before. Search for YARN-986. We can fix them here or separately.
- getRMDelegationTokenService() API: Not sure why we are doing
{{yarnConf.set(YarnConfiguration.RM_HA_ID, rmId);}}. And like I mentioned
before,
{code}
+ services.add(SecurityUtil.buildTokenService(
+ yarnConf.getSocketAddr(YarnConfiguration.RM_ADDRESS,
+ YarnConfiguration.DEFAULT_RM_ADDRESS,
+ YarnConfiguration.DEFAULT_RM_PORT)).toString());
{code}
is looking at RM_ADDRESS instead of
HAUtil.addSuffix(YarnConfiguration.RM_ADDRESS, rmId). It should do the later,
no?
> RM DT token service should have service addresses of both RMs
> -------------------------------------------------------------
>
> Key: YARN-986
> URL: https://issues.apache.org/jira/browse/YARN-986
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Vinod Kumar Vavilapalli
> Assignee: Karthik Kambatla
> Priority: Blocker
> Attachments: yarn-986-1.patch, yarn-986-2.patch,
> yarn-986-prelim-0.patch
>
>
> Previously: YARN should use cluster-id as token service address
> This needs to be done to support non-ip based fail over of RM. Once the
> server sets the token service address to be this generic ClusterId/ServiceId,
> clients can translate it to appropriate final IP and then be able to select
> tokens via TokenSelectors.
> Some workarounds for other related issues were put in place at YARN-945.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
