[ 
https://issues.apache.org/jira/browse/YARN-1774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13918835#comment-13918835
 ] 

Sandy Ryza commented on YARN-1774:
----------------------------------

Thanks for picking this up Anubhav.

A couple nits:
* In the test, writing out the xml file can be avoided.  
scheduler.getQueueManager().getLeafQueue("parent.child.granchild1", true) will 
create the queue and its parents.
* If an app is rejected in this way, "Application rejected by queue placement 
policy" will be printed out, which is not entirely accurate.  I'm not sure what 
the cleanest way to fix this, but perhaps either merging assignAppToQueue into 
addApplication or getLeafQueue could throw an exception that gets caught in 
addApplication.
* "Cannot find queue named " + queueName + " or its not a leaf queue".  This 
won't occur when the queue can't be found, only when it can't exist as a leaf 
queue given the current hierarchy.  Also, need an apostrophe in the "it's".



> FS: Submitting to non-leaf queue throws NPE
> -------------------------------------------
>
>                 Key: YARN-1774
>                 URL: https://issues.apache.org/jira/browse/YARN-1774
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.3.0
>            Reporter: Anubhav Dhoot
>            Assignee: Anubhav Dhoot
>            Priority: Blocker
>         Attachments: YARN-1774.patch
>
>
> If you create a hierarchy of queues and assign a job to parent queue, 
> FairScheduler quits with a NPE.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to