[ 
https://issues.apache.org/jira/browse/YARN-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sangjin Lee updated YARN-1771:
------------------------------

    Attachment: yarn-1771.patch

I have submitted a new patch.

I'm now using Future<FileStatus> as the value in the loading cache so that it 
can memoize the negative result. I think that's the best way to achieve this to 
report the original exceptions. I thought about using Optional, but I think 
Future works better in this case (as it can include the value or the 
exception). The code becomes slightly more complicated as a result.

I also moved the code that creates the CacheLoader to FSDownload so the related 
logic is co-located within FSDownload.

Also made isPublic package-private.

> many getFileStatus calls made from node manager for localizing a public 
> distributed cache resource
> --------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1771
>                 URL: https://issues.apache.org/jira/browse/YARN-1771
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.3.0
>            Reporter: Sangjin Lee
>            Assignee: Sangjin Lee
>            Priority: Critical
>         Attachments: yarn-1771.patch, yarn-1771.patch, yarn-1771.patch, 
> yarn-1771.patch
>
>
> We're observing that the getFileStatus calls are putting a fair amount of 
> load on the name node as part of checking the public-ness for localizing a 
> resource that belong in the public cache.
> We see 7 getFileStatus calls made for each of these resource. We should look 
> into reducing the number of calls to the name node. One example:
> {noformat}
> 2014-02-27 18:07:27,351 INFO audit: ... cmd=getfileinfo       
> src=/tmp/temp-887708724/tmp883330348/foo-0.0.44.jar ...
> 2014-02-27 18:07:27,352 INFO audit: ... cmd=getfileinfo       
> src=/tmp/temp-887708724/tmp883330348/foo-0.0.44.jar ...
> 2014-02-27 18:07:27,352 INFO audit: ... cmd=getfileinfo       
> src=/tmp/temp-887708724/tmp883330348 ...
> 2014-02-27 18:07:27,353 INFO audit: ... cmd=getfileinfo       
> src=/tmp/temp-887708724 ...
> 2014-02-27 18:07:27,353 INFO audit: ... cmd=getfileinfo       src=/tmp ...
> 2014-02-27 18:07:27,354 INFO audit: ... cmd=getfileinfo       src=/    ...
> 2014-02-27 18:07:27,354 INFO audit: ... cmd=getfileinfo       
> src=/tmp/temp-887708724/tmp883330348/foo-0.0.44.jar ...
> 2014-02-27 18:07:27,355 INFO audit: ... cmd=open      
> src=/tmp/temp-887708724/tmp883330348/foo-0.0.44.jar ...
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to