[ 
https://issues.apache.org/jira/browse/YARN-1833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13935313#comment-13935313
 ] 

Akira AJISAKA commented on YARN-1833:
-------------------------------------

I understand the test will fail if testuser belongs to 3 
(={{groupBefore.size()}}) groups. +1 for removing the assertion.
In addition, I think the test will fail in trunk also.

> TestRMAdminService Fails in branch-2
> ------------------------------------
>
>                 Key: YARN-1833
>                 URL: https://issues.apache.org/jira/browse/YARN-1833
>             Project: Hadoop YARN
>          Issue Type: Bug
>    Affects Versions: 2.4.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>
> In the test 
> testRefreshUserToGroupsMappingsWithFileSystemBasedConfigurationProvider, the 
> following assert is not needed.
> {code}
> Assert.assertTrue(groupWithInit.size() != groupBefore.size());
> {code}
> As the assert takes the default groups for groupWithInit (which in my case 
> are users, sshusers and wheel), it fails as the size of both groupWithInit 
> and groupBefore are same.
> I do not think we need to have this assert here. Moreover we are also 
> checking that the groupInit does not have the userGroups that are in the 
> groupBefore so removing the assert may not be harmful.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to