[
https://issues.apache.org/jira/browse/YARN-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13942492#comment-13942492
]
Zhijie Shen commented on YARN-1809:
-----------------------------------
bq. 2. Why we cant have delegationtoken related api's to Base Protocol?
Yes, I think it should, but I prefer to put it in ApplicationBaseProtocol when
ApplicationHistoryClientService has implemented DT related methods.
bq. 3. ApplicationHistoryClientService -> Why we removing protocol handler? I
think we should keep it as it was.
I want to make ClientRMService and ApplicationHistoryClientService are
identical in structure, and we don't need the additional call of
getClientHandler() every time we want to get the ApplicationBaseProtocol impl.
bq. 4. I am not sure why we removed the ApplicationContext, I think
ApplicationContext shoule be retained Isn't it that good if we have the
following structure
ApplicationBaseProtocol and ApplicationContext are completely different things.
ApplicationBaseProtocol is the PRC interface. Previously, I thought we should
have a uniformed ApplicationContext: on the RM side, it wraps RMContext; while
on the AHS side, it wraps ApplicationHistory. However, inspired by
RMWebServices#getApps, I think the RPC interface is a better place to uniform
the way of retrieving app info, so I created ApplicationBaseProtocol. And
ApplicationContext is no longer useful.
bq. 5. There are lot of refactoring in the patch , which is good but we could
have seprated in two JIRAs which will make changes central to specific issue.
Thoughts?
I understand the big patch is desperate for review, but I've to do that because
the patch is aiming to refactor the code to avoid duplicate web-UI code for RM
and for AHS. The two webUI should share the common code path, and then display
similarly.
> Synchronize RM and Generic History Service Web-UIs
> --------------------------------------------------
>
> Key: YARN-1809
> URL: https://issues.apache.org/jira/browse/YARN-1809
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-1809.1.patch, YARN-1809.2.patch, YARN-1809.3.patch,
> YARN-1809.4.patch, YARN-1809.5.patch, YARN-1809.5.patch, YARN-1809.6.patch
>
>
> After YARN-953, the web-UI of generic history service is provide more
> information than that of RM, the details about app attempt and container.
> It's good to provide similar web-UIs, but retrieve the data from separate
> source, i.e., RM cache and history store respectively.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
