[ 
https://issues.apache.org/jira/browse/YARN-1776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943585#comment-13943585
 ] 

Jian He commented on YARN-1776:
-------------------------------

Some comments on the patch:
- completeRenewRecords -> checkAndResumeUpdateOperation?
- 
updateRMDelegationTokenAndSequenceNumberState->updateRMDelegationTokenAndSequenceNumberInternal
 ?
- For ZK, we may just use setData, instead of remove and create znode for 
updates.
- Test for FSRMStateStore: we need a test to verify on recovery, if 
encountering  a .new file, we should resume the update operation. Essentially, 
completeRenewRecords needs test. 

> renewDelegationToken should survive RM failover
> -----------------------------------------------
>
>                 Key: YARN-1776
>                 URL: https://issues.apache.org/jira/browse/YARN-1776
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-1776.1.patch, YARN-1776.2.patch, YARN-1776.3.patch
>
>
> When a delegation token is renewed, two RMStateStore operations: 1) removing 
> the old DT, and 2) storing the new DT will happen. If RM fails in between. 
> There would be problem.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to