[
https://issues.apache.org/jira/browse/YARN-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13943827#comment-13943827
]
Zhijie Shen commented on YARN-1577:
-----------------------------------
1. Put a bracket, otherwise, ```+ ", waiting for current attempt to reach " +
attemptState''' will be concat together. if false
{code}
attemptReport == null
+ ? "N/A" : attemptReport.getYarnApplicationAttemptState()
{code}
2. If interrupted, the loop is still going on. It's the expected?
{code}
// Check app status every 1 second.
try {
Thread.sleep(1000);
} catch (InterruptedException e) {
LOG.debug("Thread sleep in monitoring loop interrupted");
}
{code}
{code}
+ } catch (InterruptedException e) {
+ LOG.warn("Interrupted while waiting for current attempt of " + appId
+ + " to reach " + attemptState);
+ }
{code}
3. In launchAM, should we remove the following assertion, as it is done before
calling launchAM
{code}
if (report.getYarnApplicationState() != YarnApplicationState.ACCEPTED) {
throw new YarnException(
"Umanaged AM must be in ACCEPTED state before launching");
}
{code}
> Unmanaged AM is broken because of YARN-1493
> -------------------------------------------
>
> Key: YARN-1577
> URL: https://issues.apache.org/jira/browse/YARN-1577
> Project: Hadoop YARN
> Issue Type: Sub-task
> Affects Versions: 2.3.0
> Reporter: Jian He
> Assignee: Jian He
> Priority: Blocker
> Attachments: YARN-1577.1.patch, YARN-1577.2.patch, YARN-1577.3.patch
>
>
> Today unmanaged AM client is waiting for app state to be Accepted to launch
> the AM. This is broken since we changed in YARN-1493 to start the attempt
> after the application is Accepted. We may need to introduce an attempt state
> report that client can rely on to query the attempt state and choose to
> launch the unmanaged AM.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
