[ 
https://issues.apache.org/jira/browse/YARN-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13944539#comment-13944539
 ] 

Jian He commented on YARN-1852:
-------------------------------

Hi [~rohithsharma], just walked through the code again. We should not send the 
ATTEMPT_FAILED/ATTEMPT_KILLED events, if the app was supposed to recover to the 
final state. We should send the events only if the app was not able to recover 
it self. I think the following "RMAppImpl.isAppInFinalState" has some problem, 
it's checking against the move-to state, while by the time this method is 
called, the app has not yet moved to this state. We may check against 
RMApp.recoveredFinalState state instead?
{code}
// We will replay the final attempt only if last attempt is in final
        // state but application is not in final state.
        if (rmApp.getCurrentAppAttempt() == appAttempt
            && !RMAppImpl.isAppInFinalState(rmApp)
{code}

> Application recovery throws InvalidStateTransitonException for FAILED and 
> KILLED jobs
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-1852
>                 URL: https://issues.apache.org/jira/browse/YARN-1852
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.3.0, 2.4.0
>            Reporter: Rohith
>            Assignee: Rohith
>         Attachments: YARN-1852.2.patch, YARN-1852.patch
>
>
> Recovering for failed/killed application throw InvalidStateTransitonException.
> These are logged during recovery of applications.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to