[
https://issues.apache.org/jira/browse/YARN-1521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945736#comment-13945736
]
Jian He commented on YARN-1521:
-------------------------------
post initial review：
- this doesn’t seem correct, user is possible to get multiple delegation
tokens. Given this change, user can only get one token
{code}
// check whether the token exists or not.
// If this token existed, recover the token with
// DelegationTokenInformation
{code}
- Explicitly assert the App does not exist in RMStateStore or not.
{code}
// After submission, the applicationState will
// not be saved in RMStateStore
{code}
- Explicitly assert the app exists in RMContext after the 2nd RM comes Active.
{code}
// Submit Application
// After submission, the applicationState will be saved in RMStateStore.
{code}
- The bulk of test-specific hack in MiniYarnCluster can be moved to
TestHAProtocol, as MiniYarnCluster is commonly used by others.
> Mark appropriate protocol methods with the idempotent annotation or
> AtMostOnce annotation
> -----------------------------------------------------------------------------------------
>
> Key: YARN-1521
> URL: https://issues.apache.org/jira/browse/YARN-1521
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Attachments: YARN-1521.0.patch
>
>
> After YARN-1028, we add the automatically failover into RMProxy. This JIRA is
> to identify whether we need to add idempotent annotation and which methods
> can be marked as idempotent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
