[
https://issues.apache.org/jira/browse/YARN-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945787#comment-13945787
]
Hadoop QA commented on YARN-1865:
---------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636441/YARN-1865.2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3447//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3447//console
This message is automatically generated.
> ShellScriptBuilder does not check for some error conditions
> -----------------------------------------------------------
>
> Key: YARN-1865
> URL: https://issues.apache.org/jira/browse/YARN-1865
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 3.0.0, 2.2.0, 2.3.0
> Reporter: Remus Rusanu
> Assignee: Remus Rusanu
> Priority: Minor
> Attachments: YARN-1865.1.patch, YARN-1865.2.patch
>
>
> The WindowsShellScriptBuilder does not check for commands exceeding windows
> maximum shell command line length (8191 chars)
> Neither Unix nor Windows script builder do not check for error condition
> after mkdir nor link
> WindowsShellScriptBuilder mkdir is not safe with regard to paths containing
> spaces
--
This message was sent by Atlassian JIRA
(v6.2#6252)
