[
https://issues.apache.org/jira/browse/YARN-1869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13950431#comment-13950431
]
Tsuyoshi OZAWA commented on YARN-1869:
--------------------------------------
[~BlueArrow], Thank you for pointing. At first I focused on fixing critical
section of zkAcl. From maintenance's point of view, we should discuss whether
updateRMDelegationTokenAndSequeceNumberInternal() should be synchronized or not
before doing this. It accesses some instance fields which needs
synchronization. IMHO, the method should be synchronized for simplicity.
[~kkambatl], can you take a look?
> Access to zkAcl should be synchronized in ZKRMStateStore#addStoreOrUpdateOps()
> ------------------------------------------------------------------------------
>
> Key: YARN-1869
> URL: https://issues.apache.org/jira/browse/YARN-1869
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
> Attachments: yarn-1869.patch
>
>
> Here is related code:
> {code}
> } else {
> opList.add(Op.create(nodeCreatePath, tokenOs.toByteArray(), zkAcl,
> CreateMode.PERSISTENT));
> }
> {code}
> The other methods accessing zkAcl are synchronized.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
