[ 
https://issues.apache.org/jira/browse/YARN-1893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954598#comment-13954598
 ] 

Xuan Gong commented on YARN-1893:
---------------------------------

bq. Seems we never had a test for testing AMRMToken works in failover scenario. 
To unblock this , can you at least manually test AMRMToken works in failover? 
We can add the test separately.

Right. Create a separate ticket to track this: 
https://issues.apache.org/jira/browse/YARN-1895
Do the manual test to verify AMRMToken works in failover

bq. One nit, you can use addPersistedPassword instead of creating a new 
getPasswords method in AMRMTokenSecretManager.

Right. Create a new patch to fix it.

> Make ApplicationMasterProtocol#allocate AtMostOnce
> --------------------------------------------------
>
>                 Key: YARN-1893
>                 URL: https://issues.apache.org/jira/browse/YARN-1893
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Xuan Gong
>            Assignee: Xuan Gong
>            Priority: Blocker
>         Attachments: YARN-1893.1.patch, YARN-1893.1.patch, YARN-1893.2.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to