[
https://issues.apache.org/jira/browse/YARN-1923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13965919#comment-13965919
]
Sandy Ryza commented on YARN-1923:
----------------------------------
A couple nits. Otherwise, LGTM.
There's a false whitespace change.
Also,
{code}
+ }
+ else if (resourceRatio <
{code}
"else" should be on the same line as the closing curly brace.
"resourceRatio" isn't really an accurate name for the variable. "resourceUsed"
might make more sense.
> Make FairScheduler resource ratio calculations terminate faster
> ---------------------------------------------------------------
>
> Key: YARN-1923
> URL: https://issues.apache.org/jira/browse/YARN-1923
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: scheduler
> Reporter: Anubhav Dhoot
> Assignee: Anubhav Dhoot
> Attachments: YARN-1923.patch
>
>
> In fair scheduler computing shares continues till iterations are complete
> even when we have a perfect match between the resource shares and total
> resources. This is because the binary search checks only less or greater and
> not equals. Add an early termination condition when its equal
--
This message was sent by Atlassian JIRA
(v6.2#6252)
