[ 
https://issues.apache.org/jira/browse/YARN-1928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967969#comment-13967969
 ] 

Vinod Kumar Vavilapalli commented on YARN-1928:
-----------------------------------------------

The reasoning and the patch look good to me. +1. Will check this in.

One side note is that on register, AMs are not getting notified of all nodes in 
the system. That will be taken care of at YARN-435, at which point this test 
will need to change.

> TestAMRMRPCNodeUpdates fails ocassionally
> -----------------------------------------
>
>                 Key: YARN-1928
>                 URL: https://issues.apache.org/jira/browse/YARN-1928
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Zhijie Shen
>            Assignee: Zhijie Shen
>         Attachments: YARN-1928.1.patch
>
>
> {code}
> junit.framework.AssertionFailedError: expected:<0> but was:<4>
>       at junit.framework.Assert.fail(Assert.java:50)
>       at junit.framework.Assert.failNotEquals(Assert.java:287)
>       at junit.framework.Assert.assertEquals(Assert.java:67)
>       at junit.framework.Assert.assertEquals(Assert.java:199)
>       at junit.framework.Assert.assertEquals(Assert.java:205)
>       at 
> org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRMRPCNodeUpdates.testAMRMUnusableNodes(TestAMRMRPCNodeUpdates.java:136)
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to