[ 
https://issues.apache.org/jira/browse/YARN-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973234#comment-13973234
 ] 

Hadoop QA commented on YARN-1940:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12640662/YARN-1940-v2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3586//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3586//console

This message is automatically generated.

> deleteAsUser() terminates early without deleting more files on error
> --------------------------------------------------------------------
>
>                 Key: YARN-1940
>                 URL: https://issues.apache.org/jira/browse/YARN-1940
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Kihwal Lee
>            Assignee: Rushabh S Shah
>         Attachments: YARN-1940-v2.patch, YARN-1940.patch
>
>
> In container-executor.c, delete_path() returns early when unlink() against a 
> file or a symlink fails. We have seen many cases of the error being ENOENT, 
> which can safely be ignored during delete.  
> This is what we saw recently: An app mistakenly created a large number of 
> files in the local directory and the deletion service failed to delete a 
> significant portion of them due to this bug. Repeatedly hitting this on the 
> same node led to exhaustion of inodes in one of the partitions.
> Beside ignoring ENOENT,  delete_path() can simply skip the failed one and 
> continue in some cases, rather than aborting and leaving files behind.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to