[
https://issues.apache.org/jira/browse/YARN-1506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976056#comment-13976056
]
Jian He commented on YARN-1506:
-------------------------------
some comments on the patch, mostly cosmetic changes:
- Since it’s changed to asynchronous, we may change the log to not say
*successfully*.
{code}
LOG.info("Update resource successfully on node(" + node.getNodeID()
+") with resource(" + newResourceOption.toString() + ")");
{code}
- Log inside UpdateNodeResourceWhenNonRunningTransition, good for debugging as
this should be an unusual case. UpdateNodeResourceWhenNonRunningTransition ->
UpdateNodeResourceWhenNotRunningTransition ?
- IMO, since UpdateNodeResourceWhenUnusableTransition and
UpdateNodeResourceWhenNonRunningTransition are the same except one extra
logging, we can do the logging for both and just keep one transition?
- if possible, nodeResourceUpdate method can be moved into
AbstractYarnScheduler, a new common base class for sharing common code among
all the schedulers.
- SchedulerNode.setTotalResource ->
SchedulerNode.updateTotalAndAvailableResource() ?
- UpdateNodeResourceResponse should be an abstract class which implements
newInstance() method.
> Replace set resource change on RMNode/SchedulerNode directly with event
> notification.
> -------------------------------------------------------------------------------------
>
> Key: YARN-1506
> URL: https://issues.apache.org/jira/browse/YARN-1506
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, scheduler
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: YARN-1506-v1.patch, YARN-1506-v10.patch,
> YARN-1506-v2.patch, YARN-1506-v3.patch, YARN-1506-v4.patch,
> YARN-1506-v5.patch, YARN-1506-v6.patch, YARN-1506-v7.patch,
> YARN-1506-v8.patch, YARN-1506-v9.patch
>
>
> According to Vinod's comments on YARN-312
> (https://issues.apache.org/jira/browse/YARN-312?focusedCommentId=13846087&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13846087),
> we should replace RMNode.setResourceOption() with some resource change event.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
