[ 
https://issues.apache.org/jira/browse/YARN-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ming Ma updated YARN-1897:
--------------------------

    Attachment: YARN-1897-2.patch

Xuan, thanks for the early patch. here is the updated version to expand 
SignalContainerCommand and rename some methods.

1. SignalContainerResponse has a flag to indicate the request was submitted 
successfully. If it fails, the application doesn't know why. Is that the 
diagnosis string for? Previous patch just throws exception.

2. There is no unit test just for this patch. I tested it manually with related 
changes in YarnCLI and RM to verify messages are being passed properly. When 
other work items in RM and NM are added, unit tests will be added accordingly.

> Define SignalContainerRequest and SignalContainerResponse
> ---------------------------------------------------------
>
>                 Key: YARN-1897
>                 URL: https://issues.apache.org/jira/browse/YARN-1897
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api
>            Reporter: Ming Ma
>         Attachments: YARN-1897-2.patch, YARN-1897.1.patch
>
>
> We need to define SignalContainerRequest and SignalContainerResponse first as 
> they are needed by other sub tasks. SignalContainerRequest should use 
> OS-independent commands and provide a way to application to specify "reason" 
> for diagnosis. SignalContainerResponse might be empty.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to