[
https://issues.apache.org/jira/browse/YARN-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13980273#comment-13980273
]
Xuan Gong commented on YARN-1897:
---------------------------------
bq. 1. SignalContainerResponse has a flag to indicate the request was submitted
successfully. If it fails, the application doesn't know why. Is that the
diagnosis string for? Previous patch just throws exception.
Yes. just throwing an exception should be fine.
I just uploaded a new patch with a little modification. I removed @see
ApplicationClientProtocol#signalContainer from both SignalContainerRequest and
SignalContainerResponse. Right now, we do not have signalContainer in
ApplicationClientProtocol. To make a clean build, I just remove them first. We
can add them back later. The other javadoc warning is unrelated. Will create a
spearate ticket for it.
Also, I marked @unstable to SignalContainerResponse API instead of @stable.
think this api might be changed later.
> Define SignalContainerRequest and SignalContainerResponse
> ---------------------------------------------------------
>
> Key: YARN-1897
> URL: https://issues.apache.org/jira/browse/YARN-1897
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: api
> Reporter: Ming Ma
> Attachments: YARN-1897-2.patch, YARN-1897-3.patch, YARN-1897.1.patch
>
>
> We need to define SignalContainerRequest and SignalContainerResponse first as
> they are needed by other sub tasks. SignalContainerRequest should use
> OS-independent commands and provide a way to application to specify "reason"
> for diagnosis. SignalContainerResponse might be empty.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
