[ https://issues.apache.org/jira/browse/YARN-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13983943#comment-13983943 ]
Hadoop QA commented on YARN-1957: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12642329/YARN-1957.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/3650//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3650//console This message is automatically generated. > ProportionalCapacitPreemptionPolicy handling of corner cases... > --------------------------------------------------------------- > > Key: YARN-1957 > URL: https://issues.apache.org/jira/browse/YARN-1957 > Project: Hadoop YARN > Issue Type: Bug > Components: resourcemanager > Affects Versions: 2.4.0 > Reporter: Carlo Curino > Assignee: Carlo Curino > Labels: capacity-scheduler, preemption > Attachments: YARN-1957.patch, YARN-1957.patch, YARN-1957_test.patch > > > The current version of ProportionalCapacityPreemptionPolicy should be > improved to deal with the following two scenarios: > 1) when rebalancing over-capacity allocations, it potentially preempts > without considering the maxCapacity constraints of a queue (i.e., preempting > possibly more than strictly necessary) > 2) a zero capacity queue is preempted even if there is no demand (coherent > with old use of zero-capacity to disabled queues) > The proposed patch fixes both issues, and introduce few new test cases. -- This message was sent by Atlassian JIRA (v6.2#6252)