[ 
https://issues.apache.org/jira/browse/YARN-1368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13987182#comment-13987182
 ] 

Sandy Ryza commented on YARN-1368:
----------------------------------

+1 to sharing common code between schedulers where possible.  However, the 
patch proposed on this JIRA leaves two separate accountings for the nodes in 
the cluster - one inside AbstractYarnScheduler and one inside the specific 
schedulers.  As [~leftnoteasy] pointed out, if we want to merge scheduler code, 
it's probably best to do so in a patch that's separate from adding the 
re-population logic.

A meta-comment - [~jianhe], if you have concerns about an approach / prototype 
it's better to provide feedback than to rewrite it yourself.

> Common work to re-populate containers’ state into scheduler
> -----------------------------------------------------------
>
>                 Key: YARN-1368
>                 URL: https://issues.apache.org/jira/browse/YARN-1368
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Anubhav Dhoot
>         Attachments: YARN-1368.preliminary.patch
>
>
> YARN-1367 adds support for the NM to tell the RM about all currently running 
> containers upon registration. The RM needs to send this information to the 
> schedulers along with the NODE_ADDED_EVENT so that the schedulers can recover 
> the current allocation state of the cluster.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to