[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994683#comment-13994683
 ] 

Chen He commented on YARN-2042:
-------------------------------

string.isEmpty() is supported by Java 1.6 and later. For compatibility, 
"string.length != 0" may be  the most efficient way. Patch is provided.

> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> --------------------------------------------------------------------------------------------
>
>                 Key: YARN-2042
>                 URL: https://issues.apache.org/jira/browse/YARN-2042
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Chen He
>            Priority: Minor
>         Attachments: YARN-2042.patch
>
>
> {code}
>       if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to