[
https://issues.apache.org/jira/browse/YARN-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994837#comment-13994837
]
Karthik Kambatla commented on YARN-1474:
----------------------------------------
# Correct me if I am wrong, but changes to AllocationFileLoaderService look
unrelated. Can we do it in a different JIRA?
# Nothing to do with this patch, but may be we can add spaces between each
interface ResourceSchedulerWrapper implements?
{code}
public class ResourceSchedulerWrapper extends AbstractYarnScheduler
implements SchedulerWrapper,ResourceScheduler,Configurable {
{code}
# Correct me if I am wrong. We need to set the rmContext only once. Can we
update the comment to say, need to call this immediately after instantiating a
scheduler?
# Do we need the changes to {{reinitialize()}} implementations in each
scheduler? Also, don't think we need a separate serviceInitInternal. Why not
just have serviceInit call reinitialize?
# FairScheduler: we can do without these variables.
{code}
private volatile boolean isUpdateThreadRunning = false;
private volatile boolean isSchedulingThreadRunning = false;
{code}
# FairScheduler: serviceStartInternal and serviceStopInternal are fairly small
methods - do we need these separate methods?
# Can we call join(timeout) after interrupt, may be use a constant
THREAD_JOIN_TIMEOUT = 1000? Also, set updateThread to null after join.
{code}
if (updateThread != null) {
updateThread.interrupt();
}
{code}
# Check for schedulingThread is null? Also, set the thread to null after join()
{code}
if (continuousSchedulingEnabled) {
isSchedulingThreadRunning = false;
schedulingThread.interrupt();
}
{code}
> Make schedulers services
> ------------------------
>
> Key: YARN-1474
> URL: https://issues.apache.org/jira/browse/YARN-1474
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: scheduler
> Affects Versions: 2.3.0
> Reporter: Sandy Ryza
> Assignee: Tsuyoshi OZAWA
> Attachments: YARN-1474.1.patch, YARN-1474.10.patch,
> YARN-1474.11.patch, YARN-1474.2.patch, YARN-1474.3.patch, YARN-1474.4.patch,
> YARN-1474.5.patch, YARN-1474.6.patch, YARN-1474.7.patch, YARN-1474.8.patch,
> YARN-1474.9.patch
>
>
> Schedulers currently have a reinitialize but no start and stop. Fitting them
> into the YARN service model would make things more coherent.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
