Jason Lowe commented on YARN-1515:

I apologize for the long delay in reviewing and resulting upmerge it caused.  
Patch looks good to me with just some minor comments:

- StopContainerRequest#getDumpThreads#getDumpThreads should have javadocs and 
interface annotations like the other methods
- Why is StopContainersRequest#getStopRequests marked Unstable but 
setStopRequests is Stable?
- Nit: dumpThreads is an event-specific field, would be nice to have an 
AMLauncherCleanupEvent that takes just the app attempt in the constructor and 
derives from AMLauncherEvent.

> Ability to dump the container threads and stop the containers in a single RPC
> -----------------------------------------------------------------------------
>                 Key: YARN-1515
>                 URL: https://issues.apache.org/jira/browse/YARN-1515
>             Project: Hadoop YARN
>          Issue Type: New Feature
>          Components: api, nodemanager
>            Reporter: Gera Shegalov
>            Assignee: Gera Shegalov
>         Attachments: YARN-1515.v01.patch, YARN-1515.v02.patch, 
> YARN-1515.v03.patch, YARN-1515.v04.patch, YARN-1515.v05.patch, 
> YARN-1515.v06.patch
> This is needed to implement MAPREDUCE-5044 to enable thread diagnostics for 
> timed-out task attempts.

This message was sent by Atlassian JIRA

Reply via email to