[ 
https://issues.apache.org/jira/browse/YARN-2011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993395#comment-13993395
 ] 

Junping Du commented on YARN-2011:
----------------------------------

Nice catch, [~airbots]! There is also a warning that following code in 
testAppAttemptMetrics() is never used:
{code}
    FiCaSchedulerApp app_0 = new FiCaSchedulerApp(appAttemptId_0, user_0, a, 
null,
        rmContext);
{code}
Given you already there, would you like to fix this warning in your patch as 
well? I will review and commit it. Thanks!

> Typo in TestLeafQueue
> ---------------------
>
>                 Key: YARN-2011
>                 URL: https://issues.apache.org/jira/browse/YARN-2011
>             Project: Hadoop YARN
>          Issue Type: Test
>    Affects Versions: 2.4.0
>            Reporter: Chen He
>            Assignee: Chen He
>            Priority: Trivial
>         Attachments: YARN-2011.patch
>
>
> a.assignContainers(clusterResource, node_0);
>     assertEquals(2*GB, a.getUsedResources().getMemory());
>     assertEquals(2*GB, app_0.getCurrentConsumption().getMemory());
>     assertEquals(0*GB, app_1.getCurrentConsumption().getMemory());
>     assertEquals(0*GB, app_0.getHeadroom().getMemory()); // User limit = 2G
>     assertEquals(0*GB, app_0.getHeadroom().getMemory()); // User limit = 2G
>     // Again one to user_0 since he hasn't exceeded user limit yet
>     a.assignContainers(clusterResource, node_0);
>     assertEquals(3*GB, a.getUsedResources().getMemory());
>     assertEquals(2*GB, app_0.getCurrentConsumption().getMemory());
>     assertEquals(1*GB, app_1.getCurrentConsumption().getMemory());
>     assertEquals(0*GB, app_0.getHeadroom().getMemory()); // 3G - 2G
>     assertEquals(0*GB, app_0.getHeadroom().getMemory()); // 3G - 2G



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to