Hadoop QA commented on YARN-2078:

{color:green}+1 overall{color}.  Here are the results of testing the latest 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3768//console

This message is automatically generated.

> yarn.app.am.resource.mb/cpu-vcores affects uber mode but is not documented
> --------------------------------------------------------------------------
>                 Key: YARN-2078
>                 URL: https://issues.apache.org/jira/browse/YARN-2078
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: documentation
>    Affects Versions: 2.4.0
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>            Priority: Trivial
>         Attachments: YARN-2078.1.patch
> We should document the condition when uber mode is enabled. If not, users 
> need to read code.
> {code}
>     boolean smallMemory =
>         ( (Math.max(conf.getLong(MRJobConfig.MAP_MEMORY_MB, 0),
>             conf.getLong(MRJobConfig.REDUCE_MEMORY_MB, 0))
>             <= sysMemSizeForUberSlot)
>             || (sysMemSizeForUberSlot == JobConf.DISABLED_MEMORY_LIMIT));
>    boolean smallCpu =
>             Math.max(
>                 conf.getInt(
>                     MRJobConfig.MAP_CPU_VCORES, 
>                     MRJobConfig.DEFAULT_MAP_CPU_VCORES), 
>                 conf.getInt(
>                     MRJobConfig.REDUCE_CPU_VCORES, 
>                     MRJobConfig.DEFAULT_REDUCE_CPU_VCORES)) 
>              <= sysCPUSizeForUberSlot
> {code}

This message was sent by Atlassian JIRA

Reply via email to