Hadoop QA commented on YARN-1569:

{color:red}-1 overall{color}.  Here are the results of testing the latest 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 


    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3777//console

This message is automatically generated.

> For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler, 
> SchedulerEvent should get checked (instanceof) for appropriate type before 
> casting
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>                 Key: YARN-1569
>                 URL: https://issues.apache.org/jira/browse/YARN-1569
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: Junping Du
>            Assignee: zhihai xu
>            Priority: Minor
>              Labels: newbie
>         Attachments: yarn-1569.patch
> As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we should 
> always check appropriate type before casting. 
> handle(SchedulerEvent) in FifoScheduler and CapacityScheduler didn't check so 
> far (no bug there now) but should be improved as FairScheduler.

This message was sent by Atlassian JIRA

Reply via email to