[ 
https://issues.apache.org/jira/browse/YARN-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004170#comment-14004170
 ] 

zhihai xu commented on YARN-1569:
---------------------------------

TestRMRestart is passed in my local repo.
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 188.438 sec - 
in org.apache.hadoop.yarn.server.resourcemanager.TestRMRestart
Results :
Tests run: 21, Failures: 0, Errors: 0, Skipped: 0


> For handle(SchedulerEvent) in FifoScheduler and CapacityScheduler, 
> SchedulerEvent should get checked (instanceof) for appropriate type before 
> casting
> -----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-1569
>                 URL: https://issues.apache.org/jira/browse/YARN-1569
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>            Reporter: Junping Du
>            Assignee: zhihai xu
>            Priority: Minor
>              Labels: newbie
>         Attachments: yarn-1569.patch
>
>
> As following: http://wiki.apache.org/hadoop/CodeReviewChecklist, we should 
> always check appropriate type before casting. 
> handle(SchedulerEvent) in FifoScheduler and CapacityScheduler didn't check so 
> far (no bug there now) but should be improved as FairScheduler.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to