Binglin Chang updated YARN-2088:

    Attachment: YARN-2088.v1.patch

Bug and fixes:
1. clear builder before adding Set/Lists
2. remove unnecessary maybeInitBuilder in mergeLocalToBuilder
3. we don't need to construct Iterable manually, just use guava library
4. the property limit is not set properly in mergeLocalToBuilder, this may 
cause the limit property be reset to Long.MAX...
5. add a test assertion in TestGetApplicationsRequest to verify the bug

Run the test on my local laptop, the test failed before the patch, and success 
after the patch. 

> Fix code bug in GetApplicationsRequestPBImpl#mergeLocalToBuilder
> ----------------------------------------------------------------
>                 Key: YARN-2088
>                 URL: https://issues.apache.org/jira/browse/YARN-2088
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: YARN-2088.v1.patch
> Some fields(set,list) are added to proto builders many times, we need to 
> clear those fields before add, otherwise the result proto contains more 
> contents.

This message was sent by Atlassian JIRA

Reply via email to