Jian He updated YARN-2017:

    Attachment: YARN-2017.6.patch

Thanks Vinod for the review !

Fixed the comments.
bq. he new node classes have a lot of getReserverdContainer() calls which can 
be replaced by a single call assigned to a local variable.
FicaSchedulerNode#reserveResource: parameter reservedContainer is renamed to 
container, similarly for FSSchedulerNode. single getReserverdContainer() call 
is used upfront.

Suppressed the find bugs warnings.

> Merge some of the common lib code in schedulers
> -----------------------------------------------
>                 Key: YARN-2017
>                 URL: https://issues.apache.org/jira/browse/YARN-2017
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-2017.1.patch, YARN-2017.2.patch, YARN-2017.3.patch, 
> YARN-2017.4.patch, YARN-2017.4.patch, YARN-2017.5.patch, YARN-2017.6.patch
> A bunch of same code is repeated among schedulers, e.g:  between 
> FicaSchedulerNode and FSSchedulerNode. It's good to merge and share them in a 
> common base.

This message was sent by Atlassian JIRA

Reply via email to